Re: Prevent printing "next step instructions" in initdb and pg_upgrade

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Prevent printing "next step instructions" in initdb and pg_upgrade
Date: 2021-02-03 15:21:17
Message-ID: 455845d1-441d-cc40-d2a7-b47f4e422489@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-01-17 14:38, Magnus Hagander wrote:
> On Thu, Jan 7, 2021 at 11:53 AM Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>>
>> After pondering this again, I think we can go with initdb
>> --no-instructions, as in your patch.
>>
>> As a minor nitpick, I would leave out the
>>
>> else
>> printf(_("\nSuccess.\n"));
>>
>> in the --no-instructions case.
>
> OK, thanks. I have applied it as such, with that message moved inside
> the if statement.

It appears that there is an extra blank line in the initdb output before
"Success" now.

--
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2021-02-03 15:24:12 Re: Dumping/restoring fails on inherited generated column
Previous Message Tom Lane 2021-02-03 15:08:37 Re: Can we have a new SQL callable function to get Postmaster PID?