Re: Prevent printing "next step instructions" in initdb and pg_upgrade

On Thu, Jan 7, 2021 at 11:53 AM Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> After pondering this again, I think we can go with initdb
> --no-instructions, as in your patch.
>
> As a minor nitpick, I would leave out the
>
> else
> printf(_("\nSuccess.\n"));
>
> in the --no-instructions case.

OK, thanks. I have applied it as such, with that message moved inside
the if statement.

> (I don't know where the pg_upgrade part of this discussion is right now.)

Yeah, I think that one turned into quite a different discussion. I
think it's clear to say that the part of this patch related to
pg_upgrade was rejected - I'll drop that one. I think pg_upgrade
scripts has to be thought about as a completely separate thing, so
let's leave that for another thread.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/