Re: Fix a possible socket leak at Windows (src/backend/port/win32/socket.c)

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix a possible socket leak at Windows (src/backend/port/win32/socket.c)
Date: 2024-01-15 12:43:03
Message-ID: 42CD72BE-2B13-43C3-989D-C1E3D987C842@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 13 Jan 2024, at 22:38, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:

> In the pgwin32_socket function (src/backend/port/win32/socket.c), there is a possible socket leak if the socket cannot be made non-blocking.

I don't know Windows well enough to comment on the implications of not calling
closesocket here, but it definitely seems like a prudent thing to do
backpatched down to 12. Unless objections I'll do that.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alena Rybakina 2024-01-15 13:21:05 Re: POC: GROUP BY optimization
Previous Message Li, Yong 2024-01-15 12:21:44 Re: archive modules loose ends