Re: Fix a possible socket leak at Windows (src/backend/port/win32/socket.c)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix a possible socket leak at Windows (src/backend/port/win32/socket.c)
Date: 2024-01-16 20:25:39
Message-ID: CAEudQAoJ6_wZR_Ui+M4e9LHvcfo0Nnuhqghhrs068jSPdovA4w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em seg., 15 de jan. de 2024 às 09:43, Daniel Gustafsson <daniel(at)yesql(dot)se>
escreveu:

> > On 13 Jan 2024, at 22:38, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>
> > In the pgwin32_socket function (src/backend/port/win32/socket.c), there
> is a possible socket leak if the socket cannot be made non-blocking.
>
> I don't know Windows well enough to comment on the implications of not
> calling
> closesocket here, but it definitely seems like a prudent thing to do
> backpatched down to 12. Unless objections I'll do that.
>
Thanks for taking care of this.
Do you have plans or should I register for a commitfest?

Best regards,
Ranier Vilela

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2024-01-16 20:25:58 Re: UUID v7
Previous Message Matthias van de Meent 2024-01-16 20:22:15 Re: cleanup patches for incremental backup