| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Luke Lonergan <llonergan(at)greenplum(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)surnet(dot)cl>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Alon Goldshuv <agoldshuv(at)greenplum(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: COPY FROM performance improvements |
| Date: | 2005-06-27 20:20:24 |
| Message-ID: | 42C05F88.7000105@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches pgsql-performance |
Luke Lonergan wrote:
>Andrew,
>
>
>
>>You might like to look at running pgindent (see src/tools/pgindent) over
>>the file before cutting a patch. Since this is usually run over each
>>file just before a release, the only badness should be things from
>>recent patches.
>>
>>
>
>I've attached two patches, one gained from running pgindent against the
>current CVS tip copy.c (:-D) and one gained by running the COPY FROM perf
>improvements through the same. Nifty tool!
>
>Only formatting changes in these.
>
>
>
>
Luke,
Something strange has happened. I suspect that you've inadvertantly used
GNU indent or an unpatched BSD indent. pgindent needs a special patched
BSD indent to work according to the PG standards - see the README
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Victor Y. Yegorov | 2005-06-27 20:35:54 | slight changes to gist.sgml |
| Previous Message | Jim C. Nasby | 2005-06-27 19:50:55 | Re: Problem with dblink regression test |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jean-Max Reymond | 2005-06-27 20:46:48 | perl garbage collector |
| Previous Message | Luke Lonergan | 2005-06-27 18:52:30 | Re: COPY FROM performance improvements |