Re: Re: [BUGS] Re: BUG #9555: pg_dump for tables with inheritance recreates the table with the wrong order of columns

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, majid(at)apsalar(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [BUGS] Re: BUG #9555: pg_dump for tables with inheritance recreates the table with the wrong order of columns
Date: 2014-08-31 16:50:35
Message-ID: 4268.1409503835@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> I have developed the attached patch to warn about column reordering in
> this odd case. The patch mentions the reordering of c:

> NOTICE: merging column "a" with inherited definition
> NOTICE: merging column "c" with inherited definition; column moved earlier to match inherited column location

This does not comport with our error message style guidelines.
You could put the additional information as an errdetail sentence,
perhaps.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message David G Johnston 2014-08-31 17:46:04 Re: [BUGS] Re: BUG #9555: pg_dump for tables with inheritance recreates the table with the wrong order of columns
Previous Message artem01x 2014-08-31 16:09:30 BUG #11316: install error

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2014-08-31 17:41:06 Re: Built-in binning functions
Previous Message Atri Sharma 2014-08-31 16:11:38 Re: Final Patch for GROUPING SETS - unrecognized node type: 347