Re: Missing hook for UPPERREL_PARTIAL_GROUP_AGG rels?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Erik Nordström <erik(at)timescale(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Missing hook for UPPERREL_PARTIAL_GROUP_AGG rels?
Date: 2019-06-27 18:58:53
Message-ID: 4241.1561661933@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?UTF-8?Q?Erik_Nordstr=C3=B6m?= <erik(at)timescale(dot)com> writes:
> I noticed that the create_upper_paths_hook is never called for partially
> grouped rels. Is this intentional or a bug? Only the FDW routine's
> GetForeignUpperPaths hook is called for partially grouped rels. This seems
> odd since the regular create_upper_paths_hook gets called for all other
> upper rels.

This seems possibly related to the discussion re set_rel_pathlist_hook
at

https://www.postgresql.org/message-id/flat/CADsUR0AaPx4sVgmnuVJ_bOkocccQZGubv6HajzW826rbSmFpCg%40mail.gmail.com

I don't think we've quite resolved what to do there, but maybe
create_upper_paths_hook needs to be looked at at the same time.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-06-27 19:16:59 Re: Hypothetical indexes using BRIN broken since pg10
Previous Message Tom Lane 2019-06-27 18:54:37 Re: Hypothetical indexes using BRIN broken since pg10