From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Hypothetical indexes using BRIN broken since pg10 |
Date: | 2019-06-27 18:54:37 |
Message-ID: | 4079.1561661677@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> On 2019-Jun-27, Julien Rouhaud wrote:
>> On Thu, Jun 27, 2019 at 8:14 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>>> I think it would look nicer to have a routine parallel to brinGetStats()
>>> (brinGetStatsHypothetical?), instead of polluting selfuncs.c with these
>>> gory details.
>> I'm not opposed to it, but I used the same approach as a similar fix
>> for gincostestimate() (see 7fb008c5ee5).
> How many #define lines did you have to add to selfuncs there?
FWIW, the proposed patch doesn't seem to me like it adds much more
BRIN-specific knowledge to brincostestimate than is there already.
I think a more useful response to your modularity concern would be
to move all the [indextype]costestimate functions out of the common
selfuncs.c file and into per-AM files. I fooled around with that
while trying to refactor selfuncs.c back in February, but I didn't
come up with something that seemed clearly better. Still, as we
move into a world with external index AMs, I think we're going to
have to make that happen eventually.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-06-27 18:58:53 | Re: Missing hook for UPPERREL_PARTIAL_GROUP_AGG rels? |
Previous Message | Erik Nordström | 2019-06-27 18:54:04 | Missing hook for UPPERREL_PARTIAL_GROUP_AGG rels? |