| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: confusing message in check_tuple |
| Date: | 2025-06-17 05:21:13 |
| Message-ID: | 41ea2006-4d0a-4de3-ac10-c99d31be5e72@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12.06.25 08:26, jian he wrote:
> in contrib/amcheck/verify_heapam.c, check_tuple
> report_corruption(ctx,
> psprintf("number of attributes %u exceeds
> maximum expected for table %u",
> ctx->natts,
> RelationGetDescr(ctx->rel)->natts));
Agreed this is misleading.
> i think it should be
> report_corruption(ctx,
> psprintf("number of attributes %u exceeds
> maximum expected for table %u",
> ctx->natts,
> RelationGetRelid(ctx->rel)));
>
> or we can rephrase it another way, also mentioning
> ``RelationGetDescr(ctx->rel)->natts``.
I think they did want to mention RelationGetDescr(ctx->rel)->natts. How
about
"number of attributes %u exceeds maximum expected for table (%u)"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-06-17 05:27:28 | Re: wrong comments in rewriteTargetListIU |
| Previous Message | Peter Eisentraut | 2025-06-17 05:15:31 | Re: fix: propagate M4 env variable to flex subprocess |