confusing message in check_tuple

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: confusing message in check_tuple
Date: 2025-06-12 06:26:29
Message-ID: CACJufxFx-25XQV+r23oku7ZnL958P30hyb9cFeYPv6wv7yzCCw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

hi.

in contrib/amcheck/verify_heapam.c, check_tuple
report_corruption(ctx,
psprintf("number of attributes %u exceeds
maximum expected for table %u",
ctx->natts,
RelationGetDescr(ctx->rel)->natts));
i think it should be
report_corruption(ctx,
psprintf("number of attributes %u exceeds
maximum expected for table %u",
ctx->natts,
RelationGetRelid(ctx->rel)));

or we can rephrase it another way, also mentioning
``RelationGetDescr(ctx->rel)->natts``.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2025-06-12 06:27:42 Re: Possibly hard-to-read message
Previous Message Noboru Saito 2025-06-12 06:13:12 Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths