Re: wrong comments in rewriteTargetListIU

On 10.04.25 11:46, Amit Langote wrote:
> Hi,
>
> On Thu, Apr 10, 2025 at 5:58 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>>
>> hi.
>>
>> in function, rewriteTargetListIU
>> we have:
>>
>> for (attrno = 1; attrno <= numattrs; attrno++)
>> {
>> /*
>> * Can only insert DEFAULT into generated columns, regardless of
>> * any OVERRIDING clauses.
>> */
>> if (att_tup->attgenerated && !apply_default)
>> }
>>
>> I think the above comments are wrong, since there are no
>> OVERRIDING clauses for the generated column.
>
> Hmm, I'm not sure that is quite right. See 17958972fe3b which added
> the comment, especially the test cases that it adds.

Jian is right, there are no OVERRIDING clauses for generated columns,
and the shown code also doesn't check for them, so the comment doesn't
match the code. I suspect that commit 17958972fe3b slightly confused
generated and identity columns in this case. I suggest to remove the
half-sentence "regardless of ...".