| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Alexandre Felipe <o(dot)alexandre(dot)felipe(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_regress: schedule multi-line test groups |
| Date: | 2026-09-18 09:30:47 |
| Message-ID: | 41CF553C-6303-4CC6-B114-85B4011799C2@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 17 Sep 2026, at 10:43, Alexandre Felipe <o(dot)alexandre(dot)felipe(at)gmail(dot)com> wrote:
> Actually, I think we should support arbitrary size test groups and run them on a pool
> from a queue that would possibly make the regression faster as today we always
> wait for the slowest test in each group.
I know of ongoing, as of yet unpublished, work in this area to improve this
scheduling which will also change the syntax. There is a bit complexity to it
than just picking from a pool since there are inter-suite dependencies.
+ /*
+ * Found `test: # no tests` treat it as a multiline test group
+ */
if (num_tests == 0)
{
- bail("syntax error in schedule file \"%s\" line %d: %s",
- schedule, line_num, scbuf);
+ multiline_test = true;
+ }
This will allow empty test groups which we currently treat as an error. This
schedule:
test: test_setup\n
test:\n
\n
test:\n
Parses and runs with all tests succeeded:
# initializing database system by copying initdb template
# using temp instance on port 40058 with PID 71845
ok 1 - test_setup 448 ms
# parallel group (0 tests):
# parallel group (0 tests):
1..1
# All 1 tests passed.
# test succeeded
Without the patch an empty group will throw an error, and I think it makes
sense to preserve that behaviour.
Also, if we are to change the accepted syntax, why limit to single line or
multiline, why not accept any whitespace separated name between ^test: and
(^test|EOF)? Something like the below:
test: boolean
char
name
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2026-09-18 09:46:00 | Re: RFC: Logging plan of the running query |
| Previous Message | Etsuro Fujita | 2026-09-18 09:23:04 | Re: Several issues with postgres_fdw stats import |