| From: | Alexandre Felipe <o(dot)alexandre(dot)felipe(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_regress: schedule multi-line test groups |
| Date: | 2026-09-17 08:43:04 |
| Message-ID: | CAE8JnxMXqCTxgcuO_rx4UnrL_3_R=dKQ9BsKObN3xdxnQ6FthA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 17, 2026 at 9:03 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Thu, Sep 17, 2026 at 08:57:51AM +0100, Alexandre Felipe wrote:
> > This was motivated by two rebases on the SLOPE patch [1] this week due to
> > changes in parallel_schedule. Also I find much easier to parse the list
> > using this syntax, if we stick with one test per line we get the benefit
> of
> > counting tests by looking at the line numbers.
> >
> > I used a `goto` to keep the number of touched lines small, and facilitate
> > your review.
I'd +1 something like that in the schedule files, even if we only
> limit the number of tests per line to be up to 20.
>
Actually, I think we should support arbitrary size test groups and run them
on a pool
from a queue that would possibly make the regression faster as today we
always
wait for the slowest test in each group.
> +test:
> + boolean
> + char
> + name
>
> At least, let's make the whitespace vs tab policy consistent. ;)
>
I will blame the editor, I hit tab and it adds spaces :) I started manually
but then I saw that
what I was doing was dumb and error prone, and did the rest with find and
replace (with \t)
now all using spaces.
Regards,
Alexandre
| Attachment | Content-Type | Size |
|---|---|---|
| v1.1-0001-pg_regress-multi-line-test-groups.patch | application/octet-stream | 11.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2026-09-17 08:45:37 | Re: Open SSI correctness issues |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-09-17 08:42:06 | RE: [PATCH] Explain what the default output_plugin_libraries do |