Re: Several issues with postgres_fdw stats import

On Thu, Sep 17, 2026 at 2:58 AM Corey Huinker <corey(dot)huinker(at)gmail(dot)com> wrote:
> On Wed, Sep 16, 2026 at 6:25 AM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:

>> As the error message says, the cause of this is that the name type
>> isn't collatable in v11. It was made so in v12, so I fixed this by
>> just s/attname COLLATE "C"/attname::text COLLATE "C"/ to the query
>> generated for v11 or older.
>
> +1

>> Also, I fixed another bug in the same function: a typo in the if-test
>> to check whether the remote server is v9.2 or later.

> +1.

Pushed/backpatched.

> This is a good argument for #define-ing the relevant server version numbers going forward.

Seams like a good idea.

Thanks for looking!

Best regards,
Etsuro Fujita