| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Hypothetical indexes using BRIN broken since pg10 |
| Date: | 2019-06-27 18:46:01 |
| Message-ID: | 20190627184601.GA32018@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Jun-27, Julien Rouhaud wrote:
> On Thu, Jun 27, 2019 at 8:14 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > I think it would look nicer to have a routine parallel to brinGetStats()
> > (brinGetStatsHypothetical?), instead of polluting selfuncs.c with these
> > gory details.
>
> I'm not opposed to it, but I used the same approach as a similar fix
> for gincostestimate() (see 7fb008c5ee5).
How many #define lines did you have to add to selfuncs there?
> If we add an hypothetical
> version of brinGetStats(), we should also do it for ginGetStats().
Dunno, seems pointless. The GIN case is different.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Erik Nordström | 2019-06-27 18:54:04 | Missing hook for UPPERREL_PARTIAL_GROUP_AGG rels? |
| Previous Message | Dave Cramer | 2019-06-27 18:37:58 | Re: Fix doc bug in logical replication. |