"maxretries" option of pg_standby doesn't work as expected

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: "maxretries" option of pg_standby doesn't work as expected
Date: 2009-03-26 02:29:59
Message-ID: 3f0b79eb0903251929v5bd4c075h3b0a382b6f4bf722@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> Set the maximum number of times to retry the copy or link command

maxretries option of pg_standby is documented as above, but actually
indicates the maximum number of times to *try* the copy or link command.
So, if "-r 0" is specified, pg_standby always fails.

Attached is the patch which adjusted the code so that maxretries actually
indicates the number of retry.

Comments?

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
maxretries_0326.patch application/octet-stream 2.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-03-26 03:17:41 Re: small but useful patches for text search
Previous Message Bruce Momjian 2009-03-26 02:24:19 Re: SSL over Unix-domain sockets