Re: "maxretries" option of pg_standby doesn't work as expected

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: "maxretries" option of pg_standby doesn't work as expected
Date: 2009-03-26 22:30:22
Message-ID: 28154.1238106622@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
>> Set the maximum number of times to retry the copy or link command

> maxretries option of pg_standby is documented as above, but actually
> indicates the maximum number of times to *try* the copy or link command.
> So, if "-r 0" is specified, pg_standby always fails.

> Attached is the patch which adjusted the code so that maxretries actually
> indicates the number of retry.

Looks correct to me; applied to HEAD and 8.3. Thanks!

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-03-26 22:51:36 Re: Review: B-Tree emulation for GIN
Previous Message Jeff Davis 2009-03-26 22:29:01 Re: Review: B-Tree emulation for GIN