Re: pgsql: Fix a couple of problems pointed out by Fujii Masao in the

From: "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>
To: "Simon Riggs" <simon(at)2ndquadrant(dot)com>
Cc: "Tom Lane" <tgl(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix a couple of problems pointed out by Fujii Masao in the
Date: 2008-09-08 18:12:28
Message-ID: 3f0b79eb0809081112h7206cc7dv670a2337969fdf33@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Sep 9, 2008 at 2:28 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> First, it is possible that the history file name is not
>
> ...always...

Not always.
If the stoppoint is as same as the startpoint, the history file name
is alphabetically
later than the last WAL file name. Because the leading 24 characters
of each file name
are the same and the history file name has additional characters. On
the other hand,
if the stoppoint is larger than the startpoint, the last WAL file name
is alphabetically
later than the history file name. Because the leading 24 characters of
the last WAL
file name is later than those of the history file name.

BTW, I have one question. Why does BackupHistoryFilePath need to be duplicated
in pg_stop_backup? I think that the latter one is redundant. Am I
missing something?

regards

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2008-09-08 18:49:08 Re: pgsql: Fix a couple of problems pointed out by Fujii Masao in the
Previous Message Simon Riggs 2008-09-08 17:28:33 Re: pgsql: Fix a couple of problems pointed out by Fujii Masao in the