Re: pgsql: Fix a couple of problems pointed out by Fujii Masao in the

On Mon, 2008-09-08 at 16:42 +0000, Tom Lane wrote:
> Log Message:
> -----------
> Fix a couple of problems pointed out by Fujii Masao in the 2008-Apr-05 patch
> for pg_stop_backup.

Thanks. Just a couple of notes there:

> First, it is possible that the history file name is not

...always...

> alphabetically later than the last WAL file name, so we should explicitly
> check that both have been archived.

My test case for the original patch worked, though there were other
cases also.

> Second, the previous coding would wait
> forever if a checkpoint had managed to remove the WAL file before we look for
> it.

The original code was safe from this error. That point applies to
discussion of solution to the first point.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support