Re: pgsql: Fix a couple of problems pointed out by Fujii Masao in the

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix a couple of problems pointed out by Fujii Masao in the
Date: 2008-09-08 18:49:08
Message-ID: 1220899748.3913.249.camel@ebony.2ndQuadrant
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On Tue, 2008-09-09 at 03:12 +0900, Fujii Masao wrote:
> On Tue, Sep 9, 2008 at 2:28 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> >> First, it is possible that the history file name is not
> >
> > ...always...
>
> Not always.

Agreed. I was adding the word "always" after the word "not", sorry if
that wasn't clear.

> BTW, I have one question. Why does BackupHistoryFilePath need to be duplicated
> in pg_stop_backup? I think that the latter one is redundant. Am I
> missing something?

Duplicated? It's a different filename each time its used. One piece of
code writes the file and the other piece reads it (sometime later). The
code is executed in different processes, at different times.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message User Mkz 2008-09-08 22:34:09 plproxy - plproxy: Postgres 8.2 did not have PGDLLIMPORT on win32
Previous Message Fujii Masao 2008-09-08 18:12:28 Re: pgsql: Fix a couple of problems pointed out by Fujii Masao in the