Re: Stronger safeguard for archive recovery not to miss data

On 2021/04/06 23:01, Fujii Masao wrote:
>
>
> On 2021/04/06 20:44, David Steele wrote:
>> On 4/6/21 7:13 AM, Fujii Masao wrote:
>>>
>>> On 2021/04/06 15:59, osumi(dot)takamichi(at)fujitsu(dot)com wrote:
>>>> I just wanted to write why the error was introduced,
>>>> but it was not necessary.
>>>> We should remove and fix the first part of the sentence.
>>>
>>> So the consensus is almost the same as the latest patch?
>>> If they are not so different, I'm thinking to push the latest version atfirst.
>>> Then we can improve the docs if required.
>>
>> +1
>
> Thanks! So I pushed the patch.

The buildfarm members "drongo" and "fairywren" reported that the regression test (024_archive_recovery.pl) commit 9de9294b0c added failed with the following error. ISTM the cause of this failure is that the test calls $node->init() without "allows_streaming => 1" and which doesn't add pg_hba.conf entry for TCP/IP connection from pg_basebackup. So I think that the attached patch needs to be applied.

pg_basebackup: error: connection to server at "127.0.0.1", port 52316 failed: FATAL: no pg_hba.conf entry for replication connection from host "127.0.0.1", user "pgrunner", no encryption
Bail out! system pg_basebackup failed

I guess that only "drongo" and "fairywren" reported this issue because they are running on Windows and pg_basebackup uses TCP/IP connection. OTOH I guess that other buildfarm members running on non-Windows use Unix-domain for pg_basebackup and pg_hba.conf entry for that exists by default. So ISTM they reported no such issue.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION