| From: | Maxim Orlov <m(dot)orlov(at)postgrespro(dot)ru> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Failed assertion on standby while shutdown |
| Date: | 2021-04-05 07:30:01 |
| Message-ID: | 3c454bbe91f4ee67d9fc078926a72dc1@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-04-01 15:02, Fujii Masao wrote:
> On 2021/03/31 19:51, Maxim Orlov wrote:
>> On 2021-03-30 20:44, Maxim Orlov wrote:
>>> The following review has been posted through the commitfest
>>> application:
>>> make installcheck-world: tested, passed
>>> Implements feature: tested, passed
>>> Spec compliant: not tested
>>> Documentation: not tested
>>>
>>> All the tests passed successfully.
>>>
>>> The new status of this patch is: Ready for Committer
>>
>> The patch is good. One note, should we put a comment about
>> ShutdownRecoveryTransactionEnvironment not reentrant behaviour? Or
>> maybe rename it to ShutdownRecoveryTransactionEnvironmentOnce?
>
> +1 to add more comments into ShutdownRecoveryTransactionEnvironment().
> I did that. What about the attached patch?
>
> Regards,
Well done! In my view is just what it's needed.
---
Best regards,
Maxim Orlov.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-04-05 07:36:22 | Re: Stronger safeguard for archive recovery not to miss data |
| Previous Message | Bharath Rupireddy | 2021-04-05 07:14:06 | Re: Replication slot stats misgivings |