| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Maxim Orlov <m(dot)orlov(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Failed assertion on standby while shutdown |
| Date: | 2021-04-01 12:02:09 |
| Message-ID: | ba2c75e0-22c1-2903-6cb3-18ebc107534d@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/03/31 19:51, Maxim Orlov wrote:
> On 2021-03-30 20:44, Maxim Orlov wrote:
>> The following review has been posted through the commitfest application:
>> make installcheck-world: tested, passed
>> Implements feature: tested, passed
>> Spec compliant: not tested
>> Documentation: not tested
>>
>> All the tests passed successfully.
>>
>> The new status of this patch is: Ready for Committer
>
> The patch is good. One note, should we put a comment about ShutdownRecoveryTransactionEnvironment not reentrant behaviour? Or maybe rename it to ShutdownRecoveryTransactionEnvironmentOnce?
+1 to add more comments into ShutdownRecoveryTransactionEnvironment().
I did that. What about the attached patch?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| fix_assertion_failure_walreceiver_v2.patch | text/plain | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Rychlewski | 2021-04-01 12:26:50 | Re: DROP INDEX docs - explicit lock naming |
| Previous Message | yuzuko | 2021-04-01 11:34:53 | Re: Autovacuum on partitioned table (autoanalyze) |