From: | Joe Conway <mail(at)joeconway(dot)com> |
---|---|
To: | Mike Palmiotto <mike(dot)palmiotto(at)crunchydata(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: partitioned tables and contrib/sepgsql |
Date: | 2017-04-04 22:56:28 |
Message-ID: | 3b0f0a27-0ccf-7298-5365-87d685eeea42@joeconway.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 04/04/2017 10:02 AM, Joe Conway wrote:
> On 04/04/2017 09:55 AM, Mike Palmiotto wrote:
>> After some discussion off-list, I've rebased and udpated the patches.
>> Please see attached for further review.
>
> Thanks -- will have another look and test on a machine with selinux
> setup. Robert, did you want me to take responsibility to commit on this
> or just provide review/feedback?
I did some editorializing on these.
In particular I did not like the approach to fixing "warning: ‘tclass’
may be used uninitialized" and ended up just doing it the same as was
done elsewhere in relation.c already (set tclass = 0 in the variable
declaration). Along the way I also changed one instance of tclass from
uint16 to uint16_t for the sake of consistency.
Interestingly we figured out that the warning was present with -Og, but
not present with -O0, -O2, or -O3.
If you want to test, apply 0001a and 0001b before 0002.
Any objections?
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
Attachment | Content-Type | Size |
---|---|---|
0001a-silence-sepgsql-compiler-warning-bool.patch | text/x-diff | 702 bytes |
0001b-silence-sepgsql-compiler-warning-uninitialized.patch | text/x-diff | 1015 bytes |
0002-add-partitioned-table-support-to-sepgsql.patch | text/x-diff | 6.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tatsuo Ishii | 2017-04-04 23:34:43 | Re: Statement timeout behavior in extended queries |
Previous Message | Simon Riggs | 2017-04-04 22:06:42 | Re: increasing the default WAL segment size |