Re: pgsql: doc: Add some images

From: Jürgen Purtz <juergen(at)purtz(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: doc: Add some images
Date: 2019-08-18 15:29:30
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On 16.08.19 23:00, Alvaro Herrera wrote:
> On 2019-Mar-27, Peter Eisentraut wrote:
>> doc: Add some images
>> Add infrastructure for having images in the documentation, in SVG
>> format. Add two images to start with. See the included README file
>> for instructions.
>> Author: Jürgen Purtz <juergen(at)purtz(dot)de>
>> Author: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
> Now when I test Jürgen's new proposed image genetic-algorithm I find
> that this stuff doesn't work in VPATH builds, at least for PDF -- I
> don't get a build failure, but instead I get just a section title that
> doesn't precede any actual image. (There's a very small warning hidden
> in the tons of other fop output). If I edit the .fo file by hand to
> make the path to .svg absolute, the image appears correctly.
> I don't see any way in the fop docs to specify the base path for images.
> I'm not sure what's a good way to fix this problem in a general way.
> Would some new rule in the xslt would work?

Hello Alvaro,

it is be possible that you face the following situation: the image
subdirectory contains all ditaa and graphviz source files, but not all
corresponding svg files. Those svg files are created by the given
Makefile of this subdirectory resp. should be included in git (and
patches - what was not the case in one of my patches).

Can you acknowledge, that this is your starting situation when you miss
the graphic in PDF? If no, please give us more information: operation
system, ... . If yes, we have the following options:

a) Make sure that all svg files exists in addition to the original
source files (as it was originally planned)

b) Run make in images subdirectory manually

c) Append a line "    $(MAKE) -C images" to Makefile of sgml directory
for PDF, HTML and EPUB targets to check the dependencies within the
images subdirectory.

Kind regards, Jürgen

In response to


Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-08-18 21:12:17 pgsql: Disallow changing an inherited column's type if not all parents
Previous Message Peter Eisentraut 2019-08-18 04:54:34 pgsql: Remove obsolete reference to Irix

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-08-18 16:41:23 Re: [PATCH] minor doc fix for create-role
Previous Message Tom Lane 2019-08-18 15:00:09 Re: [PATCH] Implement INSERT SET syntax