Re: Relation bulk write facility

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com>
Subject: Re: Relation bulk write facility
Date: 2024-02-27 20:24:01
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 26/02/2024 06:18, Michael Paquier wrote:
> On Mon, Feb 26, 2024 at 09:42:03AM +0530, Robert Haas wrote:
>> On Mon, Feb 26, 2024 at 1:21 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> So, we now need to strip the remnants of AIX support from the code and
>>> docs? I don't see that much of it, but it's misleading to leave it
>>> there.
>>> (BTW, I still want to nuke the remaining snippets of HPPA support.
>>> I don't think it does anybody any good to make it look like that's
>>> still expected to work.)
>> +1 for removing things that don't work (or that we think probably don't work).
> Seeing this stuff eat developer time because of the debugging of weird
> issues while having a very limited impact for end-users is sad, so +1
> for a cleanup of any remnants if this disappears.

Here's a patch to fully remove AIX support.

One small issue that warrants some discussion (in sanity_check.sql):

> --- When ALIGNOF_DOUBLE==4 (e.g. AIX), the C ABI may impose 8-byte alignment on
> +-- When MAXIMUM_ALIGNOF==8 but ALIGNOF_DOUBLE==4, the C ABI may impose 8-byte alignment
> -- some of the C types that correspond to TYPALIGN_DOUBLE SQL types. To ensure
> -- catalog C struct layout matches catalog tuple layout, arrange for the tuple
> -- offset of each fixed-width, attalign='d' catalog column to be divisible by 8
> -- unconditionally. Keep such columns before the first NameData column of the
> -- catalog, since packagers can override NAMEDATALEN to an odd number.
> +-- (XXX: I'm not sure if any of the supported platforms have MAXIMUM_ALIGNOF==8 and
> +-- ALIGNOF_DOUBLE==4. Perhaps we should just require that

What do y'all think of adding a check for
not a requirement today, but I believe AIX was the only platform where
that was not true. With AIX gone, that combination won't be tested, and
we will probably break it sooner or later.

Heikki Linnakangas
Neon (

Attachment Content-Type Size
0001-Remove-AIX-support.patch text/x-patch 52.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-02-27 20:45:45 Re: Relation bulk write facility
Previous Message Alexander Korotkov 2024-02-27 20:03:33 Re: Bytea PL/Perl transform