Re: [PATCH] test/ssl: rework the sslfiles Makefile target

> On 10 Aug 2021, at 09:22, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Jul 30, 2021 at 03:11:49PM +0000, Jacob Champion wrote:
>> No worries, it's easy enough to unroll the expansion manually. The
>> annoyances without secondary expansion are the duplicated lines for
>> each individual CA and the need to introduce .INTERMEDIATE targets so
>> that cleanup works as intended.
>>
>> Attached is a v3 that does that, and introduces a fallback in case
>> openssl isn't on the PATH. I also missed a Makefile dependency on
>> cas.config the first time through, which has been fixed. The patch you
>> pulled out earlier is 0001 in the set.
>
> Patch 0001 is a good cleanup. Daniel, are you planning to apply that?

Yes, it’s on my todo for today.

> Regarding 0002, I am not sure. Even if this reduces a lot of
> duplication, which is really nice, enforcing .SECONDARY to not trigger
> with a change impacting Makefile.global.in does not sound very
> appealing to me in the long-run, TBH.

I personally think the increased readability and usability from what we have
today warrants the changes. Is it the use of .SECONDARY or the change in the
global Makefile you object to (or both)?

--
Daniel Gustafsson https://vmware.com/