|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Jacob Champion <pchampion(at)vmware(dot)com>|
|Cc:||"daniel(at)yesql(dot)se" <daniel(at)yesql(dot)se>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "andrew(at)dunslane(dot)net" <andrew(at)dunslane(dot)net>|
|Subject:||Re: [PATCH] test/ssl: rework the sslfiles Makefile target|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Fri, Jul 30, 2021 at 03:11:49PM +0000, Jacob Champion wrote:
> No worries, it's easy enough to unroll the expansion manually. The
> annoyances without secondary expansion are the duplicated lines for
> each individual CA and the need to introduce .INTERMEDIATE targets so
> that cleanup works as intended.
> Attached is a v3 that does that, and introduces a fallback in case
> openssl isn't on the PATH. I also missed a Makefile dependency on
> cas.config the first time through, which has been fixed. The patch you
> pulled out earlier is 0001 in the set.
Patch 0001 is a good cleanup. Daniel, are you planning to apply that?
Regarding 0002, I am not sure. Even if this reduces a lot of
duplication, which is really nice, enforcing .SECONDARY to not trigger
with a change impacting Makefile.global.in does not sound very
appealing to me in the long-run, TBH.
|Next Message||Michael Meskes||2021-08-10 07:26:31||Re: ECPG bug fix: DECALRE STATEMENT and DEALLOCATE, DESCRIBE|
|Previous Message||Michael Paquier||2021-08-10 07:09:11||Re: Segment fault when excuting SPI function On PG with commit 41c6a5be|