| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Jacob Champion <pchampion(at)vmware(dot)com>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "andrew(at)dunslane(dot)net" <andrew(at)dunslane(dot)net> |
| Subject: | Re: [PATCH] test/ssl: rework the sslfiles Makefile target |
| Date: | 2021-08-11 00:47:38 |
| Message-ID: | YRMeKp9HG4LGBQWi@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 10, 2021 at 09:36:14AM +0200, Daniel Gustafsson wrote:
> I personally think the increased readability and usability from what we have
> today warrants the changes. Is it the use of .SECONDARY or the change in the
> global Makefile you object to (or both)?
The part I am mainly objecting to is the change in Makefile.global.in,
but I have to admit after thinking about it that enforcing SECONDARY
may not be a good idea if other parts of the system rely on that, so
encouraging the use of clean_intermediates may be dangerous (Tom's
point from upthread).
I have not tried so I am not sure, but perhaps we should just focus on
reducing the number of openssl commands rather than making easier the
integration of new files? It could be possible to close the gap with
the addition of new files with some more documentation for future
hackers then?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-08-11 00:48:19 | Re: Postgres picks suboptimal index after building of an extended statistics |
| Previous Message | Peter Geoghegan | 2021-08-11 00:37:28 | Re: Next Steps with Hash Indexes |