| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Ted Yu <yuzhihong(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, drowley(at)postgresql(dot)org, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: indentation in _hash_pgaddtup() |
| Date: | 2022-11-24 20:31:54 |
| Message-ID: | 3897973.1669321914@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> After running pgindent on v2, I see it still pushes the lines out
> quite far. If I add a new line after PageGetItemId(page, and put the
> variable assignment away from the variable declaration then it looks a
> bit better. It's still 1 char over the limit.
If you wanted to be hard-nosed about 80 character width, you could
pull out the PageGetItemId call into a separate local variable.
I wasn't going to be quite that picky, but I won't object if that
seems better to you.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ted Yu | 2022-11-24 20:39:59 | Re: indentation in _hash_pgaddtup() |
| Previous Message | David Rowley | 2022-11-24 20:24:37 | Re: indentation in _hash_pgaddtup() |