Re: indentation in _hash_pgaddtup()

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Ted Yu <yuzhihong(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, drowley(at)postgresql(dot)org, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: indentation in _hash_pgaddtup()
Date: 2022-11-24 20:24:37
Message-ID: CAApHDvroyxipEt0qjnxK=_296E=1P8ERiv5-OtB21Yu1KM5G8w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 25 Nov 2022 at 04:29, Ted Yu <yuzhihong(at)gmail(dot)com> wrote:
> Here is patch v2.

After running pgindent on v2, I see it still pushes the lines out
quite far. If I add a new line after PageGetItemId(page, and put the
variable assignment away from the variable declaration then it looks a
bit better. It's still 1 char over the limit.

David

Attachment Content-Type Size
hash-pgaddtup-indent-v3.patch text/plain 1008 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-11-24 20:31:54 Re: indentation in _hash_pgaddtup()
Previous Message Andres Freund 2022-11-24 19:32:35 Re: TAP output format in pg_regress