| From: | Ted Yu <yuzhihong(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, drowley(at)postgresql(dot)org, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: indentation in _hash_pgaddtup() |
| Date: | 2022-11-24 20:39:59 |
| Message-ID: | CALte62wCJ1N8t7On8LeJfoaDrH72bqPOVvqX-hcC_ut_ynbypg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 24, 2022 at 12:31 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > After running pgindent on v2, I see it still pushes the lines out
> > quite far. If I add a new line after PageGetItemId(page, and put the
> > variable assignment away from the variable declaration then it looks a
> > bit better. It's still 1 char over the limit.
>
> If you wanted to be hard-nosed about 80 character width, you could
> pull out the PageGetItemId call into a separate local variable.
> I wasn't going to be quite that picky, but I won't object if that
> seems better to you.
>
> regards, tom lane
>
Patch v4 stores ItemId in a local variable.
| Attachment | Content-Type | Size |
|---|---|---|
| hash-pgaddtup-indent-v4.patch | application/octet-stream | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2022-11-24 20:42:50 | Re: Time delayed LR (WAS Re: logical replication restrictions) |
| Previous Message | Tom Lane | 2022-11-24 20:31:54 | Re: indentation in _hash_pgaddtup() |