| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gurjeet Singh <gurjeet(at)singh(dot)im>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Change GUC hashtable to use simplehash? |
| Date: | 2024-01-17 14:54:48 |
| Message-ID: | 3786e988-0dc6-4feb-866c-ab5215bf2394@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17/01/2024 09:15, John Naylor wrote:
> /*
> * hashfn_unstable.h
> *
> * Building blocks for creating fast inlineable hash functions. The
> * unstable designation is in contrast to hashfn.h, which cannot break
> * compatibility because hashes can be written to disk and so must produce
> * the same hashes between versions.
> *
> * The functions in this file are not guaranteed to be stable between
> * versions, and may differ by hardware platform.
These paragraphs sound a bit awkward. It kind of buries the lede, the
"these functions are not guaranteed to be stable" part, to the bottom.
Maybe something like:
"
Building blocks for creating fast inlineable hash functions. The
functions in this file are not guaranteed to be stable between versions,
and may differ by hardware platform. Hence they must not be used in
indexes or other on-disk structures. See hashfn.h if you need stability.
"
typo: licencse
Other than that, LGTM.
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-01-17 15:10:34 | Re: Add system identifier to backup manifest |
| Previous Message | Daniel Gustafsson | 2024-01-17 14:49:44 | Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs |