From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs |
Date: | 2024-01-17 14:49:44 |
Message-ID: | 871AF1A5-D102-4993-8027-A6B8EFF5B594@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 14 Dec 2023, at 14:40, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> On Fri, 6 Oct 2023 at 17:07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Not sure what that tells us about the value of changing the CI
>> logic, but it does seem like it could be worth the one-liner
>> change needed to teach buildfarm animals to ignore READMEs.
>
> I agree that it could be worth implementing this logic on buildfarm animals.
>
> In case we want to implement the same logic on the CI, I added a new
> version of the patch; it skips CI completely if the changes are only
> in the README files.
I think it makes sense to avoid wasting CI cycles on commits only changing
README files since we know it will be a no-op. A README documentation patch
going through N revisions will incur at least N full CI runs which are
resources we can spend on other things. So +1 for doing this both in CI and in
the buildfarm.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2024-01-17 14:54:48 | Re: Change GUC hashtable to use simplehash? |
Previous Message | Nikita Malakhov | 2024-01-17 14:43:30 | Re: [PATCH] Compression dictionaries for JSONB |