| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fred Yankowski <fcy(at)acm(dot)org> |
| Cc: | pgsql-patches(at)postgresql(dot)org, pgsql-ports(at)postgresql(dot)org |
| Subject: | Re: patch for minor Win32 makefile bug |
| Date: | 2001-04-02 03:23:54 |
| Message-ID: | 3610.986181834@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches pgsql-ports |
Fred Yankowski <fcy(at)acm(dot)org> writes:
> While working on a patch that allows postmaster to run as an NT service
> with Cygwin, I found minor problem in backend/Makefile. In order to add
> an additional library to the final link/build of postgres.exe, I changed
> the DLLLIBS variable in makefiles/Makefile.win. But this change had no
> effect until I removed the line in backend/Makefile that also sets
> DLLLIB, hiding the value from Makefile.win.
Hm. Clearly we should have only one definition, so I've applied your
patch. But if the one in backend/Makefile was the controlling one,
shouldn't we make the entry in makefiles/Makefile.win match what was
in Makefile? Seems like that is the value that's been tested so far.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fred Yankowski | 2001-04-02 16:36:16 | Re: patch for minor Win32 makefile bug |
| Previous Message | Christopher Kings-Lynne | 2001-04-02 01:31:43 | RE: [HACKERS] Error in the date field (with NULL value...).Thanks! |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fred Yankowski | 2001-04-02 16:36:16 | Re: patch for minor Win32 makefile bug |
| Previous Message | Christopher Kings-Lynne | 2001-04-02 01:31:43 | RE: [HACKERS] Error in the date field (with NULL value...).Thanks! |