patch for minor Win32 makefile bug

From: Fred Yankowski <fcy(at)acm(dot)org>
To: pgsql-patches(at)postgresql(dot)org
Cc: pgsql-ports(at)postgresql(dot)org
Subject: patch for minor Win32 makefile bug
Date: 2001-03-30 18:09:36
Message-ID: 3AC4CBE0.46026AD8@acm.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches pgsql-ports

Greetings,

While working on a patch that allows postmaster to run as an NT service
with Cygwin, I found minor problem in backend/Makefile. In order to add
an additional library to the final link/build of postgres.exe, I changed
the DLLLIBS variable in makefiles/Makefile.win. But this change had no
effect until I removed the line in backend/Makefile that also sets
DLLLIB, hiding the value from Makefile.win. Note that backend/Makefile
includes Makefile.global, which includes Makefile.port, which is a
symlink to Makefile.win for a Cygwin/Win32 build.

The patch for this change to backend/Makefile is attached.

--
Fred Yankowski fred(at)OntoSys(dot)com tel: +1.630.879.1312
Principal Consultant www.OntoSys.com fax: +1.630.879.1370
OntoSys, Inc 38W242 Deerpath Rd, Batavia, IL 60510, USA

--
Index: Makefile
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/backend/Makefile,v
retrieving revision 1.68
diff -u -p -r1.68 Makefile
--- Makefile 2000/11/30 20:36:10 1.68
+++ Makefile 2001/03/30 17:56:22
@@ -64,7 +64,6 @@ $(DIRS:%=%-recursive): $(top_builddir)/s

ifeq ($(MAKE_DLL), true)
DLLOBJS := $(OBJS)
-DLLLIBS := -L/usr/local/lib -lcygipc -lcrypt -lcygwin -lkernel32

postgres.def: $(DLLOBJS)
$(DLLTOOL) --export-all --output-def $@ $(DLLOBJS)

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Philip Warner 2001-03-31 14:45:31 pg_dump UDT/function dependency patch
Previous Message Justin Clift 2001-03-30 06:40:24 Modulo bug patch for 7.0.3

Browse pgsql-ports by date

  From Date Subject
Next Message Jason Tishler 2001-03-30 22:20:26 Re: Cygwin PostgreSQL Regression Test Problems (Revisited)
Previous Message Peter Eisentraut 2001-03-30 16:11:15 Re: Compiling PostgreSQL 7.x on BeOS R5?