Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value

On Mon, 26 Oct 2026 at 07:56, Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Hi,
>
> > Attached is a patch that uses defGetString() for "proto_version" and
> > "publication_names" and adds a simple test in 030_pg_recvlogical.pl
> > to confirm it works.
>
> Thanks for the patch. One question:
>
> ```
> if (parsed > PG_UINT32_MAX)
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> errmsg("proto_version \"%s\" out of range",
> strVal(defel->arg))));
> ```
>
> Here strVal() is still used, but I feel it's better to refer `val` here. We can completely remove
> the function call.
>
> Best regards,
> Hayato Kuroda
> FUJITSU LIMITED

Hi!
Looks like a real issue. I reviewed a patch, I think this is a natural
follow-up for [0]. the CREATE_REPLICATION_SLOT/ALTER_REPLICATION_SLOT
option parser only uses defGetString/defGetBoolean - pgoutput is the
only crasher.

Also, should we reject option like

ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("option \"%s\" requires a value",
"publication_names")));

instead of a generic error message from defGetString?

[0] https://github.com/postgres/postgres/commit/290bb8afe6b

--
Best regards,
Kirill Reshke