| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Antonin Houska <ah(at)cybertec(dot)at> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Dead code in adminpack |
| Date: | 2020-02-13 11:45:28 |
| Message-ID: | 20200213114528.GL1520@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 13, 2020 at 12:15:39PM +0100, Antonin Houska wrote:
> I've noticed that convert_and_check_filename() is always passed false for the
> "logAllowed" argument - someone probably forgot to remove the argument when it
> was decided that log files are no longer accepted. If the argument was removed,
> the function would become a bit simpler, see the patch.
This routine was originally named absClusterPath(), but even at its
origin point (fe59e56) this argument has never been used. So no
objections to clean up that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-02-13 11:52:45 | Re: client-side fsync() error handling |
| Previous Message | Suraj Kharage | 2020-02-13 11:44:23 | Re: allow frontend use of the backend's core hashing functions |