| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: pgsql: Fix failure to check for open() or fsync() failures. |
| Date: | 2018-12-27 01:35:22 |
| Message-ID: | 32282.1545874522@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Dec 26, 2018 at 05:55:36PM -0500, Tom Lane wrote:
>> It appears to me that the code is intentionally not worrying about
>> fsync failure, so it seems wrong for it to FATAL out if it's unable
>> to open the file to fsync it. And it surely shouldn't do so if the
>> file isn't there.
> My point is a bit different though: it seems to me that we could just
> call BasicOpenFilePerm() and remove the stat() to do exactly the same
> things, simplifying the code.
Oh, I see. Yeah, if we're ignoring errors anyway, the stat calls
seem redundant.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-12-27 02:10:39 | Re: pgsql: Fix failure to check for open() or fsync() failures. |
| Previous Message | Alexander Korotkov | 2018-12-27 01:25:23 | pgsql: Remove entry tree root conflict checking from GIN predicate lock |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-12-27 01:46:25 | Re: random() (was Re: New GUC to sample log queries) |
| Previous Message | Michael Paquier | 2018-12-27 01:34:58 | Re: random() (was Re: New GUC to sample log queries) |