Re: pgsql: Fix failure to check for open() or fsync() failures.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Subject: Re: pgsql: Fix failure to check for open() or fsync() failures.
Date: 2018-12-27 02:10:39
Message-ID: 20181227021039.GI2106@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Dec 26, 2018 at 08:35:22PM -0500, Tom Lane wrote:
> Oh, I see. Yeah, if we're ignoring errors anyway, the stat calls
> seem redundant.

For this one, I think that we could simplify as attached (this causes
open() to fail additionally because of the sync flags, but that's not
really worth worrying). Thoughts?
--
Michael

Attachment Content-Type Size
recovery-signal-simplify.patch text/x-diff 1.5 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-12-27 02:30:49 Re: pgsql: Fix failure to check for open() or fsync() failures.
Previous Message Tom Lane 2018-12-27 01:35:22 Re: pgsql: Fix failure to check for open() or fsync() failures.

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2018-12-27 02:20:20 Re: random() (was Re: New GUC to sample log queries)
Previous Message Michael Paquier 2018-12-27 02:04:33 Re: random() (was Re: New GUC to sample log queries)