| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Yurii Rashkovskii <yrashk(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Cary Huang <cary(dot)huang(at)highgo(dot)ca> |
| Subject: | Re: [PATCH] Allow Postgres to pick an unused port to listen |
| Date: | 2023-05-11 08:36:30 |
| Message-ID: | 20230511083630.ace2m5t43fefizhv@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-May-11, Yurii Rashkovskii wrote:
> Relying on a variable number of lines may be counter-productive here if we
> want postmaster.pid to be easily readable by shell scripts.
Oh, I was thinking in Peter E's proposal to list the interface/port
number pairs in a separate file named 'ports' or something like that.
> ```
> 127.0.0.1=5432 ::1=54321
> ```
>
> Basically, a space-delimited set of address/port pairs (delimited by `=` to
> allow IPv6 addresses to use a colon).
This seems a bit too creative. I'd rather have the IPv6 address in
square brackets, which clues the parser immediately as to the address
family and use colons to separate the port number. If we do go with a
separate file, which to me sounds easier than cramming it into the PID
file, then one per line is likely better, if only because line-oriented
Unix text tooling has an easier time that way.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Having your biases confirmed independently is how scientific progress is
made, and hence made our great society what it is today" (Mary Gardiner)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2023-05-11 08:55:08 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | Daniel Gustafsson | 2023-05-11 08:30:38 | Re: pg_upgrade - typo in verbose log |