Re: pg_dump Add dumping of comments on index columns

From: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>
To: higepon <higepon(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_dump Add dumping of comments on index columns
Date: 2009-07-14 07:34:21
Message-ID: 3073cc9b0907140034t461ce630n7a07e2e847e1b324@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 26, 2009 at 2:39 AM, higepon<higepon(at)gmail(dot)com> wrote:
> Hi.
>
> Here is a patch for pg_dump "Commenting on a composite-type column".
> This patch is for Todo item named "Add dumping of comments on index
> columns and composite type columns".

this one looks good to me, the only adjust i made to the patch is
change the name for the function that dump the comments from the
composite types columns for: dumpCompositeTypeColsComment that seems
more clearer to me...

the patch works just fine...

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157

Attachment Content-Type Size
pg_dump_composite_type_v2.patch text/x-diff 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2009-07-14 07:37:49 Re: Upgrading our minimum required flex version for 8.5
Previous Message Itagaki Takahiro 2009-07-14 07:26:06 Re: COPY WITH CSV FORCE QUOTE *