Re: pg_dump Add dumping of comments on index columns

From: higepon <higepon(at)gmail(dot)com>
To: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_dump Add dumping of comments on index columns
Date: 2009-07-15 03:20:47
Message-ID: f07386410907142020u602cd722y3e81025fc39f0fc3@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jaime Casanova wrote:

> this one looks good to me, the only adjust i made to the patch is

Thank you for your review!

---
Taro Minowa(Higepon)

http://www.monaos.org/
http://code.google.com/p/mosh-scheme/

On Tue, Jul 14, 2009 at 4:34 PM, Jaime
Casanova<jcasanov(at)systemguards(dot)com(dot)ec> wrote:
> On Thu, Mar 26, 2009 at 2:39 AM, higepon<higepon(at)gmail(dot)com> wrote:
>> Hi.
>>
>> Here is a patch for pg_dump "Commenting on a composite-type column".
>> This patch is for Todo item named "Add dumping of comments on index
>> columns and composite type columns".
>
> this one looks good to me, the only adjust i made to the patch is
> change the name for the function that dump the comments from the
> composite types columns for: dumpCompositeTypeColsComment that seems
> more clearer to me...
>
> the patch works just fine...
>
> --
> Atentamente,
> Jaime Casanova
> Soporte y capacitación de PostgreSQL
> Asesoría y desarrollo de sistemas
> Guayaquil - Ecuador
> Cel. +59387171157
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2009-07-15 04:32:33 Re: Synch Rep for CommitFest 2009-07
Previous Message Robert Haas 2009-07-15 02:59:05 Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros