Re: [PATCH] Tiny CREATE STATISTICS tab-completion cleanup

On 11/27/18 12:55 AM, Tomas Vondra wrote:
> Hi,
>
> On 11/26/18 5:49 PM, Dagfinn Ilmari Mannsåker wrote:
>> Hi Hackers,
>>
>> As I was hacking on the CREATE TABLE tab completions, I noticed that the
>> CREATE STATISTICS completion was checking manually for the start and end
>> of the parenthesised list instead of using the "(*)" wildcard (because
>> it predates that functionality). Attached is a patch that updates it to
>> use the modern syntax.
>>
>
> Makes sense. At first I was wondering why it was not modified by the
> patch introducing the "(*)" wildcard, but I see 121213d9 only cared
> about VACUUM, EXPLAIN and ANALYZE.
>
> The patch seems fine to me, I'll get it committed.
>

Pushed. Thanks for the patch.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services