| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Tiny CREATE STATISTICS tab-completion cleanup |
| Date: | 2018-11-26 23:55:35 |
| Message-ID: | 65551c69-46d4-305e-25fb-2e093454d660@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 11/26/18 5:49 PM, Dagfinn Ilmari Mannsåker wrote:
> Hi Hackers,
>
> As I was hacking on the CREATE TABLE tab completions, I noticed that the
> CREATE STATISTICS completion was checking manually for the start and end
> of the parenthesised list instead of using the "(*)" wildcard (because
> it predates that functionality). Attached is a patch that updates it to
> use the modern syntax.
>
Makes sense. At first I was wondering why it was not modified by the
patch introducing the "(*)" wildcard, but I see 121213d9 only cared
about VACUUM, EXPLAIN and ANALYZE.
The patch seems fine to me, I'll get it committed.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2018-11-27 00:04:46 | Re: pg_config wrongly marked as not parallel safe? |
| Previous Message | Andres Freund | 2018-11-26 23:50:25 | Re: IMMUTABLE and PARALLEL SAFE function markings |