| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Minor typo |
| Date: | 2018-11-28 00:18:39 |
| Message-ID: | 31872.1543364319@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 28 Nov 2018, at 00:43, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>> Sending it here in case anyone feels that we should do more than just
>> correct the word..? Perhaps for non-native English speakers seeing
>> "whose" used here is confusing?
> Being a non-native English speaker I think it’s fine and, in my own bias,
> commonly understood.
I agree that "which" is just wrong here, but "whose" seems a bit malaprop
as well, and it's not the only poor English in that sentence. Maybe
rewrite the whole sentence to avoid the problem?
* When wal_compression is enabled and a "hole" is removed from a full
* page image, the page image is compressed using PGLZ compression.
(BTW, is this trying to say that we don't apply compression if the page
contains no hole? If so, why not?)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-11-28 00:31:04 | Re: Minor typo |
| Previous Message | Tomas Vondra | 2018-11-28 00:01:15 | Re: [PATCH] Tiny CREATE STATISTICS tab-completion cleanup |