Re: Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea)

From: David Steele <david(at)pgmasters(dot)net>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea)
Date: 2017-04-04 13:32:24
Message-ID: 29fdda71-407e-b8aa-953a-32302d4d9f3a@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/4/17 9:11 AM, Simon Riggs wrote:
> On 4 April 2017 at 09:05, David Steele <david(at)pgmasters(dot)net> wrote:
>> Hi Tomas,
>>
>> On 4/1/17 5:40 AM, Ashutosh Sharma wrote:
>>>
>>> Apart from above comments, your patch looks good to me. I have also
>>> marked this patch as 'Waiting for Author' in the commitfest. Thanks.
>>
>> The CF has been extended until April 7 but time is still growing short
>> and this thread has been idle for three days. Please respond with a new
>> patch by 2017-04-05 00:00 AoE (UTC-12) or this submission will be marked
>> "Returned with Feedback".
>
> We know time is growing short. Is it necessary to say that on every
> single thread? What benefit do we get from that?

Hackers has become such a fire hose that I don't take it for granted
that all messages are read by everyone. This may be news to some
authors, especially those that have not responded on a thread since
March 31.

> We voted to extend the time until the deadline. In some cases we may
> well take it all the way to the deadline, so fighting you or others
> trying to reject things *before* the deadline *because* of the
> deadline seems weird.

My goal is to help people focus on patches that have a chance. At this
point I think that includes poking authors who are not being responsive
using the limited means at my disposal.

> How about we just leave everything until the deadline, then apply the
> sword swiftly to anything that remains?

I didn't take the extension to mean that I should stop CF management.
However, If you think I have exceeded my mandate over the course of the
CF, then I'm happy to discuss that.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vicky Vergara 2017-04-04 13:40:29 Re: Instead of DROP function use UPDATE pg_proc in an upgrade extension script
Previous Message Rahila Syed 2017-04-04 13:30:21 Re: Adding support for Default partition in partitioning