| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, sawada(dot)mshk(at)gmail(dot)com |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Interval for launching the table sync worker |
| Date: | 2017-04-27 10:47:26 |
| Message-ID: | 2988e12b-76ec-4a34-8fb1-bc74eb04a635@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 25/04/17 19:54, Peter Eisentraut wrote:
> I feel it's getting a bit late for reworkings of this extent, also
> considering the marginal nature of the problem we are trying to fix. My
> patch from April 18 is very localized and gets the job done.
>
> I think this is still a good direction to investigate, but if we have to
> extend the hash table API to get it done, this might not be the best time.
>
Yeah the hash API change needed is a bummer at this stage.
One thing I am missing in your patch however is cleanup of entries for
relations that finished sync. I wonder if it would be enough to just
destroy the hash when we get to empty list.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2017-04-27 11:23:46 | Re: Partition-wise aggregation/grouping |
| Previous Message | Kyotaro HORIGUCHI | 2017-04-27 09:32:41 | Re: subscription worker doesn't start immediately on eabled |