From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | masao(dot)fujii(at)gmail(dot)com |
Cc: | peter(dot)eisentraut(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: subscription worker doesn't start immediately on eabled |
Date: | 2017-04-27 09:32:41 |
Message-ID: | 20170427.183241.176638588.horiguchi.kyotaro@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Thu, 27 Apr 2017 00:51:03 +0900, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote in <CAHGQGwEQH4V2aU=wbA4Mcc+uRsrLS2rpRONLZyB2EL=f=UNypA(at)mail(dot)gmail(dot)com>
> On Wed, Apr 26, 2017 at 4:03 PM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> > At Tue, 25 Apr 2017 14:45:03 -0400, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote in <3d6a1bd0-08ce-301d-3336-ec9f623a315d(at)2ndquadrant(dot)com>
> >> On 4/6/17 08:24, Kyotaro HORIGUCHI wrote:
> >> > The attached patch wakes up launcher when a subscription is
> >> > enabled. This fails when a subscription is enabled immedaitely
> >> > after disabling but it won't be a matter.
> >>
> >> committed, thanks
> >
> > Thanks!
>
> This patch makes me think that CREATE SUBSCRIPTION should also wake up
> the launcher only when ENABLE is specified. Patch attached. Thought?
I don't think it works as expected. Disabling of a subsciption is
detected by the *worker* itself then it terminates by
itself. Only open apply transactions can prevent the behavior.
However, of course waking up the launcher either on enabling and
disabling doesn't harm anything.
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2017-04-27 10:47:26 | Re: Interval for launching the table sync worker |
Previous Message | Fabien COELHO | 2017-04-27 08:43:34 | Re: PG 10 release notes |