From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Move tablespace path re-creation from the makefiles to pg_regres |
Date: | 2021-05-18 00:57:55 |
Message-ID: | 2934410.1621299475@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, May 17, 2021 at 05:51:54PM -0400, Tom Lane wrote:
>> Say, as attached. (Windows part is untested.)
> One thing that's changing in this patch is that testtablespace would
> be created even if the input directory does not exist when using
> --make-testtablespace-dir.
Yeah, I do not see a reason for there to be a connection. It's not
pg_regress' job to decide whether the testtablespace directory is
needed or not.
> Worth noting that snprintf() is used twice instead of once to build
> the tablespace path string.
Yeah. I considered making a global variable so that there'd be
just one instance of that, but didn't think it amounted to less
mess in the end.
> The Windows part works correctly.
Thanks for testing! I'll push this after the release is tagged.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2021-05-18 01:01:54 | Re: pgsql: Move tablespace path re-creation from the makefiles to pg_regres |
Previous Message | Michael Paquier | 2021-05-18 00:26:57 | Re: pgsql: Move tablespace path re-creation from the makefiles to pg_regres |
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2021-05-18 00:58:05 | Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing. |
Previous Message | Masahiro Ikeda | 2021-05-18 00:57:18 | Re: wal stats questions |